-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support trace logging #2838
Support trace logging #2838
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2838 +/- ##
==========================================
- Coverage 84.71% 76.42% -8.29%
==========================================
Files 667 45 -622
Lines 37912 3313 -34599
Branches 4550 387 -4163
==========================================
- Hits 32116 2532 -29584
+ Misses 4462 684 -3778
+ Partials 1334 97 -1237 |
@@ -10,6 +10,14 @@ | |||
|
|||
from .utils.common import ensure_bytes | |||
|
|||
TRACE_LEVEL = 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment to detail from where this number come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 might make more sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a comment
@@ -10,6 +10,14 @@ | |||
|
|||
from .utils.common import ensure_bytes | |||
|
|||
TRACE_LEVEL = 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation
Need to see information about parts of particular functions that would be too verbose for debug level.