Support trace logging #2838
Merged
Support trace logging #2838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2838 +/- ##
==========================================
- Coverage 84.71% 76.42% -8.29%
==========================================
Files 667 45 -622
Lines 37912 3313 -34599
Branches 4550 387 -4163
==========================================
- Hits 32116 2532 -29584
+ Misses 4462 684 -3778
+ Partials 1334 97 -1237 |
gzussa
previously approved these changes
Dec 27, 2018
gzussa
reviewed
Dec 27, 2018
| @@ -10,6 +10,14 @@ | |||
|
|
|||
| from .utils.common import ensure_bytes | |||
|
|
|||
| TRACE_LEVEL = 7 | |||
There was a problem hiding this comment.
Could you add a comment to detail from where this number come from?
There was a problem hiding this comment.
gzussa
approved these changes
Dec 27, 2018
| @@ -10,6 +10,14 @@ | |||
|
|
|||
| from .utils.common import ensure_bytes | |||
|
|
|||
| TRACE_LEVEL = 7 | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Need to see information about parts of particular functions that would be too verbose for debug level.